fixup: allow Applid to include special chars #144
Conversation
| @@ -300,7 +300,7 @@ def get_arg_defs(self): # type: () -> dict | |||
| defs[STEPLIB]["options"][DATA_SETS].update({"elements": "data_set_base"}) | |||
| defs[DFHRPL]["options"][TOP_DATA_SETS].update({"elements": "data_set_base"}) | |||
| defs[DFHRPL]["options"][DATA_SETS].update({"elements": "data_set_base"}) | |||
| self.update_arg_def(defs[APPLID], "qualifier") | |||
| self.update_arg_def(defs[APPLID], "dd") | |||
There was a problem hiding this comment.
Is this type definitely right? Looking at this doc, where an applid is between 2-8 characters if this is what we are taking as the standard.
And I think type dd allows for 1 char length?
There was a problem hiding this comment.
Yeah DD would allow for 1 char as per its regex r"^[A-Z$#@][A-Z0-9@#$]{0,7}$"
But so would qualifier the one were currently using r"^[A-Z]{1}[A-Z0-9]{0,7}$"
Maybe we should add an additional length check into here somewhere
There was a problem hiding this comment.
Ah good point. Happy for this to merge as we are only improving the existing then, but should raise issue for the length atleast or just add this onto this PR if you have time? Whatever is easiest
There was a problem hiding this comment.
Lets make an issue for length, suspect its gonna be a trickier one to do
andrewhughes101
force-pushed
the
applid-bug
branch
from
8511e54 to
4bf0f7c
Compare
SUMMARY
Allows a user to specify an Applid that includes special chars $@#
ISSUE TYPE
COMPONENT NAME
region_jcl