Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix firewall_resource examples input parameters #557

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

sebastien-dargoeuves-ipf
Copy link
Contributor

In the example, we should use firewall instead of name as per the options described at the top of the documentation.

SUMMARY

I had an error on my VSCode when I used name as it was showing in the example. Looking at the documentation, it says I should be using firewall instead.
I haven't explicitly tested to see if it would have failed, but I thought replacing name with firewall was the right thing to do, as it works fine like this.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

firewall_resource

ADDITIONAL INFORMATION

In the example, we should use `firewall` instead of `name` as per the options described at the top of the documentation.
@jooola jooola changed the title firewall_resource.py - wrong examples docs: fix firewall_resource examples input parameters Sep 10, 2024
@jooola
Copy link
Collaborator

jooola commented Sep 12, 2024

Thanks for the fix!

@jooola jooola merged commit b39d762 into ansible-collections:main Sep 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants