feat(inventory): improve api options #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
inventory-cleanup
branch
2 times, most recently
from
26b7a89 to
3961f10
Compare
apricote
previously approved these changes
Nov 23, 2023
- Rename `token` option to `api_token`, use aliases for backward compatibility. - Rename `token_env` option to `api_token_env`, use aliases for backward compatibility. - Deprecate the `api_token_env` option, suggest using a lookup plugin or use the well-known `HCLOUD_TOKEN` environment variable name.
jooola
force-pushed
the
inventory-cleanup
branch
from
3961f10 to
5c4d39a
Compare
apricote
approved these changes
Nov 23, 2023
jooola
pushed a commit
that referenced
this pull request
Nov 24, 2023
🤖 I have created a release *beep* *boop* --- ## [2.4.0](2.3.0...2.4.0) (2023-11-24) ### Features * add `hetzner.hcloud.all` action group ([#396](#396)) ([6581ed5](6581ed5)) * **inventory:** improve api options ([#397](#397)) ([9905bd0](9905bd0)) * remove `hcloud_` prefix from all modules names ([#390](#390)) ([933a162](933a162)) * rename api_endpoint module argument ([#395](#395)) ([7c9fbf8](7c9fbf8)) ### Bug Fixes * **inventory:** improve performance ([#402](#402)) ([f85d8f4](f85d8f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
tokenoption toapi_token, use aliases for backward compatibility.token_envoption toapi_token_env, use aliases for backward compatibility.api_token_envoption, suggest using a lookup plugin ({{ lookup('ansible.builtin.env', 'YOUR_ENV_VAR') }}) or use the well-knownHCLOUD_TOKENenvironment variable name.api_endpointoption.ISSUE TYPE
COMPONENT NAME
hcloud inventory