Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created field to server and server_info modules #381

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat: add created field to server and server_info modules #381

merged 1 commit into from
Nov 6, 2023

Conversation

urbanekpj
Copy link
Contributor

@urbanekpj urbanekpj commented Nov 6, 2023

SUMMARY

Add missing "created" field to ansible result

based on documentation https://docs.hetzner.cloud/#servers-get-all-servers

created
string required
Point in time when the Resource was created (in ISO-8601 format)
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hcloud_server_info
hcloud_server

Copy link
Collaborator

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the contribution,

The PR is missing a changelog fragment, could you please add one ?

Here is an example:

https://github.com/ansible-collections/hetzner.hcloud/blob/084e04d576798e7b49c5c3101803e7b8d2e80181/changelogs/fragments/add-server_types-to-datacenter-info.yaml

The field is also missing from the hcloud_server module, could you also add it ?

plugins/modules/hcloud_server_info.py Outdated Show resolved Hide resolved
plugins/modules/hcloud_server_info.py Outdated Show resolved Hide resolved
plugins/modules/hcloud_server_info.py Outdated Show resolved Hide resolved
@jooola jooola changed the title Add to ServerInfo "created" field feat: add to created field to server_info module Nov 6, 2023
@jooola jooola changed the title feat: add to created field to server_info module feat: add created field to server_info module Nov 6, 2023
@urbanekpj
Copy link
Contributor Author

Thank you for hints. I think all suggestion was applied.

@jooola jooola changed the title feat: add created field to server_info module feat: add created field to server and server_info modules Nov 6, 2023
@jooola jooola merged commit c3e4c0e into ansible-collections:main Nov 6, 2023
28 checks passed
@jooola
Copy link
Collaborator

jooola commented Nov 6, 2023

Awesome! Thanks a lot!

jooola pushed a commit that referenced this pull request Nov 7, 2023
🤖 I have created a release *beep* *boop*
---


##
[2.3.0](2.2.0...2.3.0)
(2023-11-07)


### Features

* add `created` field to server and server_info modules
([#381](#381))
([c3e4c0e](c3e4c0e))
* add server_types to datacenter info module
([#379](#379))
([084e04d](084e04d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants