Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move module vars out of __init__ #336

Merged
merged 3 commits into from
Sep 26, 2023
Merged

refactor: move module vars out of __init__ #336

merged 3 commits into from
Sep 26, 2023

Conversation

jooola
Copy link
Collaborator

@jooola jooola commented Sep 25, 2023 •
edited
Loading

SUMMARY
  • move module vars out of __init__
  • add modules type hints
  • catch hcloud exception for api calls

@jooola jooola merged commit 94190ae into ansible-collections:main Sep 26, 2023
23 checks passed
@jooola jooola deleted the modules-vars branch September 26, 2023 07:41
@jooola jooola mentioned this pull request Sep 26, 2023
Merged
jooola added a commit that referenced this pull request Sep 26, 2023
@jooola
test: fix AnsibleHCloud module unit tests (#337)
f47e49c 
##### SUMMARY

We had a race condition between 2 Pull Requests (#336 and #325) and
everything didn't go through the test pipeline. Fixing it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooola @apricote