Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add unit tests to azure pipelines #325

Merged
merged 1 commit into from
Sep 26, 2023
Merged

ci: add unit tests to azure pipelines #325

merged 1 commit into from
Sep 26, 2023

Conversation

jooola
Copy link
Collaborator

@jooola jooola commented Sep 13, 2023

SUMMARY

Enable unit testing in the CI. We started to write some unit tests for the inventory, but they were not enforced in the CI.

@jooola jooola force-pushed the enable-unit-tests branch 4 times, most recently from 055fa84 to 2a8773d Compare September 25, 2023 12:35
@jooola jooola marked this pull request as ready for review September 25, 2023 12:39
@jooola jooola requested a review from apricote September 25, 2023 12:40
@webknjaz
Copy link
Member

FYI, it's also possible to run unit tests via GHA with https://github.com/marketplace/actions/ansible-test — the usage example is integrated into the template repository for collections @ https://github.com/ansible-collections/collection_template/blob/5f6a378/.github/workflows/ansible-test.yml.

@jooola
Copy link
Collaborator Author

jooola commented Sep 25, 2023

Thanks for the links, but as long as ansible-community/community-topics#237 is an issue, I do not want to migrate to Github Actions.

@webknjaz
Copy link
Member

Fair enough!

apricote
apricote approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪

@jooola jooola merged commit 9a44bc2 into ansible-collections:main Sep 26, 2023
28 checks passed
@jooola jooola deleted the enable-unit-tests branch September 26, 2023 07:41
@jooola jooola mentioned this pull request Sep 26, 2023
Merged
jooola added a commit that referenced this pull request Sep 26, 2023
@jooola
test: fix AnsibleHCloud module unit tests (#337)
f47e49c 
##### SUMMARY

We had a race condition between 2 Pull Requests (#336 and #325) and
everything didn't go through the test pipeline. Fixing it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jooola @webknjaz @apricote