fix: firewall port argument is required with udp or tcp (#345)

##### SUMMARY When managing a tcp/udp firewall rule, provide a clear error message when the port is missing from the rule. Closes #344 ##### ISSUE TYPE - Bugfix Pull Request ##### COMPONENT NAME hcloud_firewall
ansible-collections · Oct 4, 2023 · 76c1abf · 76c1abf
1 parent dc65831
commit 76c1abf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/changelogs/fragments/require-firewall-port-argument-on-tcp-or-udp-protocol.yaml b/changelogs/fragments/require-firewall-port-argument-on-tcp-or-udp-protocol.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+  - hcloud_firewall - The port argument is required when the firewall rule protocol is `udp` or `tcp`.
diff --git a/plugins/modules/hcloud_firewall.py b/plugins/modules/hcloud_firewall.py
@@ -314,6 +314,10 @@ def define_module(cls):
                         description={"type": "str"},
                     ),
                     required_together=[["direction", "protocol"]],
+                    required_if=[
+                        ["protocol", "udp", ["port"]],
+                        ["protocol", "tcp", ["port"]],
+                    ],
                 ),
                 labels={"type": "dict"},
                 state={
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- hcloud_firewall - The port argument is required when the firewall rule protocol is `udp` or `tcp`.