Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add support for src plus match:exact (?) #778

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bentole
Copy link
Contributor

@bentole bentole commented Mar 14, 2023

SUMMARY

Fixes #655
Fixes #740
Fixes #771
Fixes #129 (related)

Add support for device configuration to exactly match the provided template configuration guaranteeing consistency and idempotency.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cisco.ios.ios_config

ADDITIONAL INFORMATION

Feature best described by using an example:

play
- name: Make sure running-config exactly matches the template
  cisco.ios.ios_config:
    match: exact
    src: template.j2
template.j2
class-map match-all FOO
 description I am FOO
 match dscp af41
class-map match-all BAR
 description I am BAR
 match dscp af31
running-config before
class-map match-all FOO
 match dscp af42
 match dscp af43
commands fired
class-map match-all FOO
 no match dscp af42
 no match dscp af43
 description I am FOO
 match dscp af41
class-map match-all BAR
 description I am BAR
 match dscp af31
running-config after
class-map match-all FOO
 description I am FOO
 match dscp af41 
class-map match-all BAR
 description I am BAR
 match dscp af31 

Consecutive Runs:
changed: false aka Idempotent!

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9c36c6e7461a4eeba3ddc901cc4ff296

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 8m 34s
ansible-ee-integration-ios-latest FAILURE in 17m 02s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 41s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 16m 57s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 44s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 45m 03s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 41m 30s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 44m 51s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 41s (non-voting)
ansible-tox-linters FAILURE in 10m 31s

@bentole bentole changed the title [WIP] add support for src plus match:exact [WIP] add support for src plus match:exact (?) Mar 15, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7c3e5c7927d44f119e587e4d04c818aa

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 8m 33s
ansible-ee-integration-ios-latest FAILURE in 18m 40s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 21s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 22m 15s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 21m 43s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 1h 38m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 46m 23s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 49m 31s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 49m 45s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 18s

@KB-perByte
Copy link
Collaborator

Hey @bentole this PR has been WIP for quite sometime now, please let us know if you are stuck on anything.
Regards.

@KB-perByte KB-perByte marked this pull request as draft March 27, 2024 05:29
@amalmborg97
Copy link

Hey @KB-perByte, what changes/operations need to be made to get this PR completed? I'm willing to take this over and finish it if it has been abandoned.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants