ios_acls: Fix module failure when ARP ACLs are present on device

[Girish5tri]

SUMMARY

This PR fixes an issue with the ios_acls module where it fails when ARP ACLs are present on the device. The module was incorrectly parsing ARP ACL entries, causing errors when configuring extended ACLs with protocol options.

Initial ACL configuration:

ip access-list standard 10
 10 permit 192.168.1.0 0.0.0.255
arp access-list arp-test
 permit ip any mac any

Playbook:

  tasks:
    - name: ACL merge operation
      cisco.ios.ios_acls:
        config:
          - afi: ipv4
            acls:
              - name: ext_acl
                acl_type: extended
                aces:
                  - grant: permit
                    protocol_options:
                      ip: yes
                    source:
                      address: 192.0.2.0
                      wildcard_bits: 0.0.0.255
                    destination:
                      address: 192.0.3.0
                      wildcard_bits: 0.0.0.255

Error:

TASK [ACL merge operation] ***************************************************************************************************************************
fatal: [10.100.201.128]: FAILED! => {"changed": false, "msg": "Unsupported attribute for standard ACL - protocol."}

FIX

Changes made in ios/plugins/module_utils/network/ios/facts/acls/acls.py

    def get_acl_data(self, connection):
        # Removed the show access-list
        # Removed the show running-config | include ip(v6)* access-list|remark
        return connection.get("show running-config | section 'ip[v6]* access-list'")

This ensures the module only processes IP ACLs and ignores ARP ACLs.

Fixes: #1111

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cisco.ios.ios_acls

[KB-perByte]

Can we please add a integration test where we add a prepare test to add arp access-list and then gather facts so that we are sure with an appliance too that the facts are handled correctly?

[Girish5tri]

Sure will do it thanks