Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Android Prover Setup #10

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

[WIP] Android Prover Setup #10

wants to merge 19 commits into from

Conversation

0xVikasRushi
Copy link
Member

@0xVikasRushi 0xVikasRushi commented Dec 22, 2024 •
edited
Loading

Features

  • Added Rapidsnark library for Android proving - includes latest rapidsnark and witness calc blindings
  • Works just like iOS but with one difference: Rapidsnark.groth16ProveWithZKeyFilePath for Android doesn't need - proofBufferSize, public_buffer_size, errorBufferSize params since these are handled in Kotlin
  • Groth16Verify interface works the same as iOS version

Fixes

  • Fixed Android QR Scanner bug

Pending:

  • Download issues: Sometimes the app doesn't download the full zkey file on Android during setup. This makes the app crash if you try to generate proofs with an incomplete file. We should add a popup showing download progress so users can see what's happening, and fix the download permissions.
  • Some UI elements are not responsive on larger screens.
  • Loading screens sometimes get stuck while generating proofs

Current Benchmarks (Android)

Operation Time
Proof Generation (Rapidsnark + Witness Calc) 20.0883 seconds
Proof Verification 74 milliseconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meyanis95 Meyanis95 Awaiting requested review from Meyanis95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xVikasRushi