-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split release versions of bins and libs #4117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
approved these changes
Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 341 341
Lines 107491 107491
=======================================
+ Hits 80169 80170 +1
+ Misses 27322 27321 -1 ☔ View full report in Codecov by Sentry. |
tzemanovic
added
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
backport-libs-46
Backport libraries to 0.46 maintenance branch
and removed
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
labels
Nov 29, 2024
tzemanovic
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Nov 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
(cherry picked from commit 63dae40)
3 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 29, 2024
split release versions of bins and libs (backport #4117)
tzemanovic
added a commit
that referenced
this pull request
Nov 29, 2024
* maint-0.46: Namada libs 0.46.1 changelog: add #4117 exclude apps crate from libs release apps: don't use workspace version anymore add a script to release apps bins prefix libs release tag with "libs-" mv scripts/release.sh scripts/release_libs.sh add different commit msg for libs release add a different release config for apps Changelog Add a single CometBFT dummy validator mergify: move autosquash to queue_rules Adds debug trace for masp epochs in asset types Fix `gen_localnet.py` json exception Revert "ci(mergify): upgrade configuration to current format" Error match for shielding retry logic Changelog #4071 Refactors shielding retry logic Shielding retry logic only when masp vp rejects Improves implicit vp display Changelog #4083 Adds missing protocol params in logs Log the implicit vp in `query-protocol-parameters` mergify: backport 0.46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-libs-46
Backport libraries to 0.46 maintenance branch
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
crates/apps
will be versioned separately from everything else, starting atv1.0
v1.0.0
maint-1.0
scripts/release_bins.sh
apps
may be preceded bylibs
release with thelibs
release backported to theapps
maintenance branchv0.46.0
libs-
, e.g. next patch release tag would belibs-v.46.1
maint-libs-0.46
scripts/release_libs.sh
libs
can be released independently ofapps
at any timeCHANGELOG.md
in their release order and the libs release versions will be prefixed withlibs-
to distinguish themapps
releases will usually have their changes coming from the libs, their changelog may often only contain e.g.updated namada libraries to libs-vX.Y.Z
backport-lib-X.Y
for libs andbackport-X.Y
for appscrates/apps
is a very thin layer of main fns which dispatch most of their functionality tocrates/apps_lib
Updated release process
main
libs-vX.Y.Z
into apps maint branch before release (never merge unreleased libs branches here, such as a libs maintenance branch)updated namada libraries to libs-vX.Y.Z
to serve as a link to the change set from libsmain
and then mergemain
into latestmaint-libs-X.Y
maint-libs-X.Y
updated namada libraries to libs-vX.Y.Z
to serve as a link to the change set from libsmaint-X.Y
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo