test/e2e: mainnet phases test #4013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 74.58% 74.58% -0.01%
==========================================
Files 341 341
Lines 107484 107484
==========================================
- Hits 80167 80165 -2
- Misses 27317 27319 +2 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/phases-test
branch
2 times, most recently
from
3498de7
to
9d3c8a8
Compare
tzemanovic
force-pushed
the
tomas/phases-test
branch
3 times, most recently
from
b15ebf7
to
247f575
Compare
crates/tests/src/e2e/ledger_tests.rs
Outdated
| // IBC transfers shouldn't be allowed before phase 3 | ||
| ibc_tests::transfer_from_gaia( | ||
| &test_gaia, | ||
| GAIA_USER, | ||
| &namada_receiver, | ||
| GAIA_COIN, | ||
| 1, | ||
| &port_id_gaia, | ||
| &channel_id_gaia, | ||
| None, | ||
| None, | ||
| )?; |
There was a problem hiding this comment.
does this function ensure that the transfer fails?
There was a problem hiding this comment.
this fn doesn't fail - it gets submitted to the relayer where it hangs before timing out (or if the next phase begins first, it goes through). The balance check below that ensures that the transfer doesn't get completed before the next phase is activated
|
In general, I think we should be testing lots of actions in each phase to make sure what does and doesn't work as intended. For example, I wrote on the Namada forum some recommendations for users to test during Phase 3 and 4 of the dry-run: |
tzemanovic
force-pushed
the
tomas/phases-test
branch
from
d0864d0
to
90a6493
Compare
|
Hey @tzemanovic, what's the status here of this? |
I'm still trying to iron out some flakiness - sometimes it passes but sometimes there are pending packets left in hermes for a long time and it times out |
Describe your changes
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo