Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft+3444 #3487

Closed
wants to merge 242 commits into from
Closed

Draft+3444 #3487

wants to merge 242 commits into from

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jul 4, 2024

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

brentstone and others added 28 commits June 28, 2024 10:38
* grarco/early-sapling-balance-check:
  Extracts the sapling value balance directly in `validate_transparent_bundle`
  Changelog #2721
  Early sapling balance check in masp vp
* yuji/ibc-e2e-config:
  longer interval
  add changelog
  clear on start
  change IBC e2e test config
* grarco/opt-recomm:
  Changelog #3192
  Minor code optimizations
* grarco/streamline-validation:
  Refactors recheck of `process_proposal` before `finalize_block`
  Changelog #3448
  Clippy + fmt
  Removes redundant check in `finalize_block` and implements recheck
  Updates docs of `finalize_block` and `process_proposal`
  Moves allowed txs check in `process_proposal` before the check on fees
  Removes duplicated validation in `prepare_proposal`
  Anticipates check on tx allowlist in mempool
* fraccaman/respect-wasm-dir:
  added changelog
  respect warm-dir on init-network
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 33.85914% with 2977 lines in your changes missing coverage. Please review.

Project coverage is 53.47%. Comparing base (5cc23b4) to head (56a1cc6).

Files Patch % Lines
crates/sdk/src/masp.rs 0.46% 642 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 424 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 423 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 215 Missing ⚠️
crates/shielded_token/src/validation.rs 0.00% 158 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 86 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 77.71% 78 Missing ⚠️
crates/core/src/masp.rs 2.77% 70 Missing ⚠️
crates/node/src/shell/governance.rs 3.07% 63 Missing ⚠️
crates/apps_lib/src/client/tx.rs 0.00% 61 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3487      +/-   ##
==========================================
- Coverage   53.92%   53.47%   -0.45%     
==========================================
  Files         317      320       +3     
  Lines      107575   110000    +2425     
==========================================
+ Hits        58007    58821     +814     
- Misses      49568    51179    +1611     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants