Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
@brentstone
brentstone committed Apr 19, 2024
1 parent 773ec07 commit d5bd388
Showing 1 changed file with 84 additions and 82 deletions.
166 changes: 84 additions & 82 deletions crates/apps/src/lib/node/ledger/shell/finalize_block.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,9 @@ mod test_finalize_block {
use namada::proof_of_stake::{unjail_validator, ADDRESS as pos_address};
use namada::replay_protection;
use namada::tendermint::abci::types::{Misbehavior, MisbehaviorKind};
use namada::token::{Amount, DenominatedAmount, NATIVE_MAX_DECIMAL_PLACES};
use namada::token::{
read_balance, Amount, DenominatedAmount, NATIVE_MAX_DECIMAL_PLACES,
};
use namada::tx::data::Fee;
use namada::tx::{Authorization, Code, Data};
use namada::vote_ext::ethereum_events;
Expand Down Expand Up @@ -1755,7 +1757,7 @@ mod test_finalize_block {

let (current_epoch, inflation) =
advance_epoch(&mut shell, &pkh1, &votes, None);
total_rewards += inflation;
total_rewards += token::Amount::from(inflation);

// Query the available rewards
let query_rewards = namada_proof_of_stake::query_reward_tokens(
Expand Down Expand Up @@ -1808,7 +1810,7 @@ mod test_finalize_block {
// Go to the next epoch
let (current_epoch, inflation) =
advance_epoch(&mut shell, &pkh1, &votes, None);
total_rewards += inflation;
total_rewards += token::Amount::from(inflation);

// Unbond some tokens
let unbond_amount = token::Amount::native_whole(50_000);
Expand Down Expand Up @@ -1885,9 +1887,9 @@ mod test_finalize_block {
advance_epoch(&mut shell, &pkh1, &votes, None);
current_epoch = new_epoch;

total_rewards += inflation;
total_rewards += token::Amount::from(inflation);
if current_epoch <= pipeline_epoch_from_unbond {
missed_rewards += inflation;
missed_rewards += token::Amount::from(inflation);
}
}

Expand Down Expand Up @@ -2032,7 +2034,7 @@ mod test_finalize_block {
let (new_epoch, inflation) =
advance_epoch(&mut shell, &pkh1, &votes, None);
current_epoch = new_epoch;
total_rewards += inflation;
total_rewards += token::Amount::from(inflation);
}

// Claim the rewards for the validator for the first two epochs
Expand All @@ -2058,6 +2060,7 @@ mod test_finalize_block {
);
let (new_epoch, inflation_3) =
advance_epoch(&mut shell, &pkh1, &votes, None);
let inflation_3 = token::Amount::from(inflation_3);
current_epoch = new_epoch;
total_rewards += inflation_3;

Expand Down Expand Up @@ -3487,20 +3490,21 @@ mod test_finalize_block {
}

/// Current test procedure (prefixed by epoch in which the event occurs):
/// 0) Validator initial stake of 00_000
/// 0) Validator initial stake of 100_000
/// 1) Delegate 37_231 to validator
/// 1) Self-unbond 84_654
/// 2) Unbond delegation of 18_000
/// 3) Self-bond 9_123
/// 4) Self-unbond 15_000
/// 5) Delegate 8_144 to validator
/// 6) Discover misbehavior in epoch 3
/// 7) Discover misbehavior in epoch 4
/// 7) Discover one misbehavior in epoch 3 and one in epoch 4
/// 9) Process slashes from epoch 3
/// 10) Process slashes from epoch 4
fn test_multiple_misbehaviors_by_num_vals(
num_validators: u64,
) -> namada::state::StorageResult<()> {
// Setup the network with pipeline_len = 2, unbonding_len = 4
// let num_validators = 8_u64;
let (mut shell, _recv, _, _) = setup_with_cfg(SetupCfg {
last_height: 0,
num_validators,
Expand All @@ -3513,15 +3517,12 @@ mod test_finalize_block {

// Slash pool balance
let nam_address = shell.state.in_mem().native_token.clone();
let slash_balance_key = token::storage_key::balance_key(
let slash_pool_balance_init = read_balance(
&shell.state,
&nam_address,
&namada_proof_of_stake::SLASH_POOL_ADDRESS,
);
let slash_pool_balance_init: token::Amount = shell
.state
.read(&slash_balance_key)
.expect("must be able to read")
.unwrap_or_default();
)
.unwrap();
debug_assert_eq!(slash_pool_balance_init, token::Amount::zero());

let consensus_set: Vec<WeightedValidator> =
Expand Down Expand Up @@ -3551,8 +3552,8 @@ mod test_finalize_block {
assert!(!votes.is_empty());

// Advance to epoch 1 and
// 1. Delegate 67231 NAM to validator
// 2. Validator self-unbond 154654 NAM
// 1. Delegate 37_231 NAM to validator
// 2. Validator self-unbond 84_654 NAM
let (current_epoch, _) = advance_epoch(&mut shell, &pkh1, &votes, None);
assert_eq!(shell.state.in_mem().block.epoch.0, 1_u64);

Expand Down Expand Up @@ -3614,7 +3615,7 @@ mod test_finalize_block {
);

// Advance to epoch 2 and
// 1. Unbond 18000 NAM from delegation
// 1. Unbond 18_000 NAM from delegation
let votes = get_default_true_votes(
&shell.state,
shell.state.in_mem().block.epoch,
Expand Down Expand Up @@ -3659,7 +3660,7 @@ mod test_finalize_block {
);

// Advance to epoch 3 and
// 1. Validator self-bond 9123 NAM
// 1. Validator self-bond 9_123 NAM
let votes = get_default_true_votes(
&shell.state,
shell.state.in_mem().block.epoch,
Expand All @@ -3679,7 +3680,7 @@ mod test_finalize_block {
.unwrap();

// Advance to epoch 4
// 1. Validator self-unbond 15000 NAM
// 1. Validator self-unbond 15_000 NAM
let votes = get_default_true_votes(
&shell.state,
shell.state.in_mem().block.epoch,
Expand All @@ -3699,7 +3700,7 @@ mod test_finalize_block {
.unwrap();

// Advance to epoch 5 and
// Delegate 8144 NAM to validator
// Delegate 8_144 NAM to validator
let votes = get_default_true_votes(
&shell.state,
shell.state.in_mem().block.epoch,
Expand Down Expand Up @@ -3760,9 +3761,7 @@ mod test_finalize_block {
// Assertions
assert_eq!(current_epoch.0, 6_u64);
let processing_epoch = misbehavior_epoch
+ params.unbonding_len
+ 1_u64
+ params.cubic_slashing_window_length;
+ params.slash_processing_epoch_offset();
let enqueued_slash = enqueued_slashes_handle()
.at(&processing_epoch)
.at(&val1.address)
Expand Down Expand Up @@ -3829,20 +3828,20 @@ mod test_finalize_block {
Some(misbehaviors),
);
assert_eq!(current_epoch.0, 7_u64);
let enqueued_slashes_8 = enqueued_slashes_handle()
let enqueued_slashes_9 = enqueued_slashes_handle()
.at(&processing_epoch)
.at(&val1.address);
let enqueued_slashes_9 = enqueued_slashes_handle()
let enqueued_slashes_10 = enqueued_slashes_handle()
.at(&processing_epoch.next())
.at(&val1.address);

let num_enqueued_8 =
enqueued_slashes_8.iter(&shell.state).unwrap().count();
let num_enqueued_9 =
enqueued_slashes_9.iter(&shell.state).unwrap().count();
let num_enqueued_10 =
enqueued_slashes_10.iter(&shell.state).unwrap().count();

assert_eq!(num_enqueued_8, 2);
assert_eq!(num_enqueued_9, 1);
assert_eq!(num_enqueued_9, 2);
assert_eq!(num_enqueued_10, 1);
let last_slash =
namada_proof_of_stake::storage::read_validator_last_slash_epoch(
&shell.state,
Expand Down Expand Up @@ -3885,7 +3884,7 @@ mod test_finalize_block {
+ del_2_amount
);

tracing::debug!("\nNow processing the infractions\n");
tracing::debug!("\nNow processing the infractions from epoch 3\n");

// Advance to epoch 9, where the infractions committed in epoch 3 will
// be processed
Expand Down Expand Up @@ -3965,6 +3964,7 @@ mod test_finalize_block {
Epoch(10),
)
.unwrap();

// The amount unbonded after the infraction that affected the deltas
// before processing is `del_unbond_1_amount + self_bond_1_amount -
// self_unbond_2_amount` (since this self-bond was enacted then unbonded
Expand Down Expand Up @@ -4010,17 +4010,17 @@ mod test_finalize_block {

// Check the balance of the Slash Pool
// TODO: finish once implemented
// let slash_pool_balance: token::Amount = shell
// .state
// .read(&slash_balance_key)
// .expect("must be able to read")
// .unwrap_or_default();
// let exp_slashed_3 = decimal_mult_amount(
// std::cmp::min(Decimal::TWO * cubic_rate, Decimal::ONE),
// val_stake_3 - del_unbond_1_amount + self_bond_1_amount
// - self_unbond_2_amount,
// );
// assert_eq!(slash_pool_balance, exp_slashed_3);
let slash_pool_balance = read_balance(
&shell.state,
&staking_token,
&namada_proof_of_stake::SLASH_POOL_ADDRESS,
)
.unwrap();
let exp_slashed_3 = (val_stake_3 - del_unbond_1_amount
+ self_bond_1_amount
- self_unbond_2_amount)
.mul_ceil(std::cmp::min(Dec::two() * cubic_rate, Dec::one()));
assert!(slash_pool_balance - exp_slashed_3 <= 1.into());

// Advance to epoch 10, where the infraction committed in epoch 4 will
// be processed
Expand All @@ -4033,32 +4033,30 @@ mod test_finalize_block {

// Check the balance of the Slash Pool
// TODO: finish once implemented
// let slash_pool_balance: token::Amount = shell
// .state
// .read(&slash_balance_key)
// .expect("must be able to read")
// .unwrap_or_default();
let slash_pool_balance = read_balance(
&shell.state,
&staking_token,
&namada_proof_of_stake::SLASH_POOL_ADDRESS,
)
.unwrap();

// let exp_slashed_4 = if dec!(2) * cubic_rate >= Decimal::ONE {
// token::Amount::zero()
// } else if dec!(3) * cubic_rate >= Decimal::ONE {
// decimal_mult_amount(
// Decimal::ONE - dec!(2) * cubic_rate,
// val_stake_4 + self_bond_1_amount - self_unbond_2_amount,
// )
// } else {
// decimal_mult_amount(
// std::cmp::min(cubic_rate, Decimal::ONE),
// val_stake_4 + self_bond_1_amount - self_unbond_2_amount,
// )
// };
// dbg!(slash_pool_balance, exp_slashed_3 + exp_slashed_4);
// assert!(
// (slash_pool_balance.change()
// - (exp_slashed_3 + exp_slashed_4).change())
// .abs()
// <= 1
// );
let exp_slashed_4 = if Dec::two() * cubic_rate >= Dec::one() {
token::Amount::zero()
} else if Dec::from(3u64) * cubic_rate >= Dec::one() {
(val_stake_4 + self_bond_1_amount - self_unbond_2_amount)
.mul_ceil(Dec::one() - Dec::two() * cubic_rate)
} else {
(val_stake_4 + self_bond_1_amount - self_unbond_2_amount)
.mul_ceil(std::cmp::min(cubic_rate, Dec::one()))
};

dbg!(slash_pool_balance, exp_slashed_3 + exp_slashed_4);
assert!(
(slash_pool_balance.change()
- (exp_slashed_3 + exp_slashed_4).change())
.abs()
<= Uint::one()
);

let val_stake = read_validator_stake(
&shell.state,
Expand Down Expand Up @@ -4091,11 +4089,14 @@ mod test_finalize_block {

// dbg!(&exp_slashed_during_processing_9);
// TODO: finish once implemented
// assert!(
// ((pre_stake_11 - post_stake_11).change() -
// exp_slashed_4.change()) .abs()
// <= 1
// );
assert!(
(dbg!(
(pre_stake_10 - post_stake_10).change()
- exp_slashed_4.change()
))
.abs()
<= Uint::one()
);

// dbg!(&val_stake, &exp_stake);
// dbg!(exp_slashed_during_processing_8 +
Expand All @@ -4105,14 +4106,15 @@ mod test_finalize_block {
// exp_slashed_during_processing_9)
// );

// let exp_stake = val_stake_3 - del_unbond_1_amount +
// self_bond_1_amount
// - self_unbond_2_amount
// + del_2_amount
// - exp_slashed_3
// - exp_slashed_4;
let exp_stake = val_stake_3 - del_unbond_1_amount + self_bond_1_amount
- self_unbond_2_amount
+ del_2_amount
- exp_slashed_3
- exp_slashed_4;

// assert!((exp_stake.change() - post_stake_11.change()).abs() <= 1);
assert!(
(exp_stake.change() - post_stake_10.change()).abs() <= Uint::one()
);

for _ in 0..2 {
let votes = get_default_true_votes(
Expand Down Expand Up @@ -4662,7 +4664,7 @@ mod test_finalize_block {
proposer_address: &[u8],
consensus_votes: &[VoteInfo],
misbehaviors: Option<Vec<Misbehavior>>,
) -> (Epoch, token::Amount) {
) -> (Epoch, token::Change) {
let current_epoch = shell.state.in_mem().block.epoch;
let staking_token =
namada_proof_of_stake::staking_token_address(&shell.state);
Expand Down Expand Up @@ -4700,7 +4702,7 @@ mod test_finalize_block {

(
shell.state.in_mem().block.epoch,
pos_balance_post - pos_balance_pre,
pos_balance_post.change() - pos_balance_pre.change(),
)
}

Expand Down

0 comments on commit d5bd388

Please sign in to comment.