-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM update removed #346
NPM update removed #346
Conversation
…ltair-viz/altair_saver#113), NPMv8 is provided with container [by default](https://hub.docker.com/r/nikolaik/python-nodejs)
Tested it and can confirm it works. #337 |
v9 has a breaking change for our dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pseusys and @MarkenJaden! Rather than removing it entirely, we could set it to install latest of v8 series.
It's set by default in the container |
@pseusys could you link me to that? Because I couldn't see the {
"key": "python3.9-nodejs16",
"python": "3.9",
"python_canonical": "3.9.16",
"python_image": "3.9.16-buster",
"nodejs": "16",
"nodejs_canonical": "16.19.0",
"distro": "buster"
}, |
It's over here in the overview tab: https://hub.docker.com/r/nikolaik/python-nodejs |
Yeh, that's true. But in the table below it states that our container version uses NodeJS v16.19.0. And on its website it's written that default NPM version is 8.19.3. |
NPM update removed because of breaking changes introduced in NPMv9, NPMv8 is provided with container by default. Solves #337.