Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM update removed #346

Merged
merged 2 commits into from
Jan 12, 2023
Merged

NPM update removed #346

merged 2 commits into from
Jan 12, 2023

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented Dec 8, 2022

NPM update removed because of breaking changes introduced in NPMv9, NPMv8 is provided with container by default. Solves #337.

@MarkenJaden
Copy link
Collaborator

MarkenJaden commented Jan 6, 2023

Tested it and can confirm it works. #337

@aravindvnair99 aravindvnair99 self-assigned this Jan 12, 2023
@aravindvnair99 aravindvnair99 self-requested a review January 12, 2023 18:51
@aravindvnair99 aravindvnair99 added the dependencies Pull requests that update a dependency file label Jan 12, 2023
v9 has a breaking change for our dependency
Copy link
Collaborator

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pseusys and @MarkenJaden! Rather than removing it entirely, we could set it to install latest of v8 series.

@aravindvnair99 aravindvnair99 merged commit d20e5f3 into anmol098:master Jan 12, 2023
@pseusys
Copy link
Collaborator Author

pseusys commented Jan 12, 2023

It's set by default in the container

@aravindvnair99
Copy link
Collaborator

@pseusys could you link me to that? Because I couldn't see the npm version defined there:

    {
      "key": "python3.9-nodejs16",
      "python": "3.9",
      "python_canonical": "3.9.16",
      "python_image": "3.9.16-buster",
      "nodejs": "16",
      "nodejs_canonical": "16.19.0",
      "distro": "buster"
    },

Source: https://github.com/nikolaik/docker-python-nodejs/blob/ae91124dc8d437f2be167adfca81f614ee2b2452/versions.json#L363-L371

@pseusys
Copy link
Collaborator Author

pseusys commented Jan 12, 2023

It's over here in the overview tab: https://hub.docker.com/r/nikolaik/python-nodejs

@aravindvnair99
Copy link
Collaborator

@pseusys That's the latest tag. We don't use that. We use python3.9-nodejs16 as you see here:

FROM nikolaik/python-nodejs:python3.9-nodejs16

@pseusys
Copy link
Collaborator Author

pseusys commented Jan 13, 2023

Yeh, that's true. But in the table below it states that our container version uses NodeJS v16.19.0. And on its website it's written that default NPM version is 8.19.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG : Command '['/usr/bin/npm', 'bin', '--global']' returned non-zero exit status 1.
3 participants