Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck options without bridge #3571

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Arthur-Milchior
Copy link
Contributor

Thanks to @BrayanDSO I learned we were not supposed to have BridgeCommand anymore. So here I remove them in the deck options

@BrayanDSO
Copy link
Contributor

Reference: ankidroid/Anki-Android#14361 (comment)

@dae
Copy link
Member

dae commented Nov 17, 2024

Sorry for the delayed review. A couple of questions:

  • If 'requireClose' and 'confirmDiscardChanges' are intended only to be used by the deck options as the comment implies, I think they need a more specific name.
  • If they're intended to be used in other contexts in the future too, I think closeCurrentWindow might be a clearer name
  • Did you consider using a simple JavaScript confirm() instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants