Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump backendVersion from 0.1.8 to 0.1.9 #9070

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 4, 2021

Bumps backendVersion from 0.1.8 to 0.1.9.
Updates anki-android-backend from 0.1.8 to 0.1.9

Commits

Updates anki-android-backend-testing from 0.1.8 to 0.1.9

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `backendVersion` from 0.1.8 to 0.1.9.

Updates `anki-android-backend` from 0.1.8 to 0.1.9
- [Release notes](https://github.com/david-allison-1/Anki-Android-Backend/releases)
- [Commits](ankidroid/Anki-Android-Backend@0.1.8...0.1.9)

Updates `anki-android-backend-testing` from 0.1.8 to 0.1.9
- [Release notes](https://github.com/david-allison-1/Anki-Android-Backend/releases)
- [Commits](ankidroid/Anki-Android-Backend@0.1.8...0.1.9)

---
updated-dependencies:
- dependency-name: io.github.david-allison-1:anki-android-backend
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.github.david-allison-1:anki-android-backend-testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies used for automated dependency PRs label Jun 4, 2021
@mikehardy
Copy link
Member

@david-allison-1 I assume we will always manage these with manual requests like #9061 ?

As such I would personally do a @dependabot ignore this dependency - except in the conf file vs in the implicit rules that are stored who knows where

Which I think should look like this change I just posted on to the dependency-updates branch 9cdc4a5

based on https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#specifying-dependencies-and-versions-to-ignore

If you agree I will maintain the commit for next dependency updates PR, if not I will drop the commit

Separately and I'll peel this off for tracking: the AnkiDroid Rust backend should be under the ankidroid github org I think - we are early enough in the 2.16 cycle I think now is the best time to make the change and iron out all the random CI / docs / whatever things that will be related

@mikehardy mikehardy requested a review from david-allison June 4, 2021 15:39
@david-allison
Copy link
Member

david-allison commented Jun 5, 2021

If you agree I will maintain the commit for next dependency updates PR, if not I will drop the commit

Separately and I'll peel this off for tracking: the AnkiDroid Rust backend should be under the ankidroid github org I think - we are early enough in the 2.16 cycle I think now is the best time to make the change and iron out all the random CI / docs / whatever things that will be related

Let's update manually. Agreed

Issues are already in-place for moving to the AnkiDroid org & groupId

ankidroid/Anki-Android-Backend#32
ankidroid/Anki-Android-Backend#33

@mikehardy
Copy link
Member

Okay, commented separately on those, they have different implementation paths
I'll maintain the dependabot commit then and keep it manual for this dep - as mentioned I think that's the right path personally and easy to revert if not of course

@mikehardy mikehardy closed this Jun 5, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 5, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/dependency-updates/backendVersion-0.1.9 branch June 5, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies used for automated dependency PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants