Ensure there is at most one reviewer #17662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the code ensured there was at most one IntentHandler. We honestly don't care about it. Instead, the new code ensure that there is a single Reviewer. This bug was probably introduced in ankidroid#17422 with commit f26aa95. I would love to test to avoid another regression. However, it's really not clear to me how to deal with shortcuts, widget or remainders as they are outside of the main app. It should be noted that this is still far from ideal. Because, once you're done reviewing, you can go back to whatever view used to be opened. For example: * in the deck picker, open the deck options of deck A * reduce ankidroid, * use a shortcut or widget to open deck B * review deck B entirely You go back to the deck options of deck A, and you don't even have any context about what is the deck whose options you are currently seeing. I think ideally we should close everything, and just open the deck picker, and then the reviewer on top of it. However, as this simple fix works for what I expect to be the most common use case (regularly tapping on the shortcut/widget), I think it's still work merging it. Bug ankidroid#16956.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code ensured there was at most one IntentHandler. We honestly don't care about it. Instead, the new code ensure that there is a single Reviewer.
This bug was probably introduced in #17422 with commit f26aa95.
I would love to test to avoid another regression. However, it's really not clear to me how to deal with shortcuts, widget or remainders as they are outside of the main app.
It should be noted that this is still far from ideal. Because, once you're done reviewing, you can go back to whatever view used to be opened. For example:
You go back to the deck options of deck A, and you don't even have any context about what is the deck whose options you are currently seeing.
I think ideally we should close everything, and just open the deck picker, and then the reviewer on top of it.
However, as this simple fix works for what I expect to be the most common use case (regularly tapping on the shortcut/widget), I think it's still work merging it.
Bug #16956.