rename ViewerAction.EDIT_NOTE

[BrayanDSO]

to EDIT

this allows to share the same preference key of ViewerCommand, since the name is the same now

This change will reset its position in the toolbar, but it doesn't need a preference upgrade because the new reviewer is a developer option

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

We should have a test which breaks on changes which would invalidate preferences. Fine to do in alpha. We should do this with intent in production.

In general: it's 'edit card' if coming from the reviewer: might not be when we move to the new editor, but for now we can display the correct deck/card template if a card is provided

[BrayanDSO]

We should have a test which breaks on changes which would invalidate preferences.

Gonna do some when the new reviewer is promoted to an Advanced > Experimental setting. Not now to avoid spending time fixing emerging changes like this one

[david-allison]

Sounds good to me

[mikehardy]

LGTM as well as all related discussion about testing, and not needed in alpha etc +1