-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup]: Resolve Android Studio Warnings (#13282) #17648
base: main
Are you sure you want to change the base?
[Cleanup]: Resolve Android Studio Warnings (#13282) #17648
Conversation
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one issue to fix and then we can merge this.
@@ -22,6 +22,7 @@ import android.os.Bundle | |||
import android.os.Parcel | |||
import android.os.Parcelable | |||
import androidx.core.os.bundleOf | |||
import com.arcao.slf4j.timber.BuildConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed and squash merged
Removed unused imports and properties Made some properties private for encapsulation Fixed unresolved references (e.g., BuildConfig) Simplified 'activity' initialization removed unused import
0dc96ff
to
a0b1f48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Purpose / Description
Reducing Android Studio warnings by cleaning up unused code and fixing initialization.
Fixes
[Cleanup]: Fix Android Studio Warnings
Approach
AppCompatPreferenceActivity.kt
.CardTemplateBrowserAppearanceEditor.kt
.CardTemplateNotetype.kt
.CardTemplateNotetype.kt
.CollectionHelper.kt
.NoteEditor.kt
.activity
inRtlCompliantActionProvider.kt
by assigning it immediately during declaration, rather than inside the init block. This ensures proper initialization and avoids potential issues.Checklist
Please, go through these checks before submitting the PR.