Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pre-commit): syntax error #17631

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(pre-commit): syntax error #17631

merged 1 commit into from
Dec 19, 2024

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Dec 19, 2024

Cause: 670d1c3

I could commit again after I added this change and built the project

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Review High Priority Request for high priority review label Dec 19, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 but good catch+fix

@mikehardy mikehardy added this pull request to the merge queue Dec 19, 2024
Merged via the queue into ankidroid:main with commit cabcf4f Dec 19, 2024
12 checks passed
@github-actions github-actions bot removed the Review High Priority Request for high priority review label Dec 19, 2024
@github-actions github-actions bot added this to the 2.21 release milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants