Fetching correct DeckID at EditNote

[soCallmeAdityaKumar]

Purpose / Description

Note editor shows Default deck for all cards

Fixes

• Fixes [BUG]: Note editor shows Default deck for all cards #17604

How Has This Been Tested?

WhatsApp.Video.2024-12-16.at.2.30.32.PM.mp4

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

This isn't close to the correct solution.

The code change causing the problem was already identified on the issue.

[soCallmeAdityaKumar]

This isn't close to the correct solution.

The code change causing the problem was already identified on the issue.

This is working on my side, orginalDeckID is always 0 , giving value of deckId to did if oDid is 0. Hope new commit changes is correct solution

[david-allison]

I'm disappointed here.

I diagnosed the issue and I posted the hunk/diff of the change which caused the issue. All that was required was to revert that hunk

It's now been two rounds review for what should be an easy 'LGTM':

• The change is still wrong
• [email protected]().deckId should be [email protected]

Start again from my issue comment.

If you feel there's still an issue, explain it, or write a test for it.

[david-allison]

No reply to my comment, which wasn't addressed

You've been here for almost two years and should know better. Enough is enough here.