Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onBackPressed deprecation of CardTemplateEditor #17599

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Prince-kushwaha
Copy link
Contributor

@Prince-kushwaha Prince-kushwaha commented Dec 14, 2024

Purpose / Description

fix onBackPressed deprecation of CardTemplateEditor

Fixes

How Has This Been Tested?

Physical Device

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

One extra thing left over is a call in CardTemplateEditor's _onOptionsItemSelected()_method to the deprecated onBackPressed() that should be replaced with:

onBackPressedDispatcher.onBackPressed()

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Dec 14, 2024
@Prince-kushwaha Prince-kushwaha force-pushed the cardtemplate-deprecation branch from b488890 to 6086474 Compare December 14, 2024 16:03
@Prince-kushwaha Prince-kushwaha force-pushed the cardtemplate-deprecation branch from 6086474 to 4e5c018 Compare December 15, 2024 14:08
@Prince-kushwaha Prince-kushwaha force-pushed the cardtemplate-deprecation branch from 4e5c018 to a248373 Compare December 15, 2024 14:38
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, cheers!

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Author Reply Waiting for a reply from the original author labels Dec 15, 2024
@lukstbit lukstbit added this pull request to the merge queue Dec 15, 2024
Merged via the queue into ankidroid:main with commit 3751f14 Dec 15, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Dec 15, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants