Clean protobuf related code #17591
Merged
Clean protobuf related code #17591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
requested changes
Dec 12, 2024
| custom = customOrdering | ||
|
|
||
| is SortOrder.BuiltinSortKind -> | ||
| builtin = toProtoBuf() |
There was a problem hiding this comment.
This one needs a second look. It's correct, but the usage of an overloaded this rather than a this@ leads to confusion
AnkiDroid/src/test/java/com/ichi2/anki/BackupManagerSimpleTest.kt
Outdated
Show resolved
Hide resolved
Arthur-Milchior
force-pushed
the
builder
branch
from
07641ae to
c2fe016
Compare
While looking at the `Card` code, I decided to go over all `newBuilder`, and slightly improve the code everywhere.
Many `this` are now useless
Arthur-Milchior
force-pushed
the
builder
branch
from
c2fe016 to
6c45dab
Compare
david-allison
approved these changes
Dec 13, 2024
david-allison
added
Needs Second Approval
lukstbit
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
This was referenced Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While touching code related to card's protobuf, I saw the use the code that is too verbose and decided to improve it