Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync-conflict): Add link to manual #17580

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Giyutomioka-SS
Copy link
Contributor

Purpose / Description

Major point of confusion for users, that could be massively improved with a help icon.

Fixes

How Has This Been Tested?

Realme 6 (API-30) and Emulator

Screenshot

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@Giyutomioka-SS
Copy link
Contributor Author

Giyutomioka-SS commented Dec 9, 2024

@david-allison, need your suggestion. Here's the dialog screenshot—how can it be improved, and what should be the next steps?

Dialog Screenshot

photo_2024-12-10_00-17-56

@Giyutomioka-SS Giyutomioka-SS marked this pull request as draft December 9, 2024 18:58
@david-allison
Copy link
Member

Update the code in the following PR, so we can have all 3 of:

  • A dialog icon
  • A title
  • A 'help' icon

The link location also needs to be improved to be AnkiDroid specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Help' icon for sync conflict
2 participants