-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2 #14870
build(deps): bump org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2 #14870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorconfig property 'ktlint_disabled_rules' is obsolete and is not used by KtLint starting from version 0.49. Remove the property from all '.editorconfig' files.
KtLint found code style violations. Please see the following reports:
I fixed quite a few of these and have it running pretty well in general. It still needs a bit more manual fixing and this is a good first issue because if done well you'll learn:
|
A newer version of org.jlleitschuh.gradle.ktlint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
https://github.com/JLLeitschuh/ktlint-gradle/blob/main/CHANGELOG.md 12.0.3 doesn't look too major, easily merged into first commit via git rebase whenever I or anyone that has time takes a look |
d2974f6
to
27afe6e
Compare
Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2. --- updated-dependencies: - dependency-name: org.jlleitschuh.gradle.ktlint dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Many more still needed
which is a bad practice really, but I'm still learning how to drive the linter via suppression etc
cec9aba
to
05b4c94
Compare
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2.
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)