Skip to content

Commit

Permalink
Add FSRS library version information to about settings screen
Browse files Browse the repository at this point in the history
  • Loading branch information
@lukstbit @mikehardy
lukstbit authored and mikehardy committed Oct 25, 2024
1 parent c004aa0 commit f72114b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
1 change: 1 addition & 0 deletions .idea/dictionaries/anki.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
<w>fname</w>
<w>fnames</w>
<w>frac</w>
<w>fsrs</w>
<w>fullsync</w>
<w>gendeck</w>
<w>genrem</w>
Expand Down
3 changes: 3 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/preferences/AboutFragment.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ class AboutFragment : Fragment(R.layout.about_layout) {
view.findViewById<TextView>(R.id.about_backend).text =
"(anki " + BackendBuildConfig.ANKI_DESKTOP_VERSION + " / " + BackendBuildConfig.ANKI_COMMIT_HASH.subSequence(0, 8) + ")"

// FSRS version text
view.findViewById<TextView>(R.id.about_fsrs).text = "(FSRS ${BackendBuildConfig.FSRS_VERSION})"

// Logo secret
view.findViewById<ImageView>(R.id.about_app_logo)
.setOnClickListener(DevOptionsSecretClickListener(requireActivity() as Preferences))
Expand Down
9 changes: 8 additions & 1 deletion AnkiDroid/src/main/res/layout/about_layout.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,16 @@
style="?android:textAppearanceSmall"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginBottom="14dp"
tools:text="(anki 23.10.1 / be74babb0)" />

<TextView
android:id="@+id/about_fsrs"
style="?android:textAppearanceSmall"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginBottom="14dp"
tools:text="(FSRS 0.6.4)" />

<TextView
android:id="@+id/about_contributors_title"
android:layout_width="match_parent"
Expand Down

4 comments on commit f72114b

@chrislongros
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is support for FSRS 5 coming ? We still get the 17 parameters error :)

@mikehardy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"We" - who is we?
"error" - what exact error message are you receiving?
what version of ankidroid are you running?

There should be cross-support for FSRS-not-5 and FSRS-5 now within anki unless you were running a pre-release Anki 24.10 and it was not Anki 24.10-rc1 since I believe the cross-support between 4 and 5 was added then.

Basically: to be a good issue report, a lot more information is required

https://stackoverflow.com/help/how-to-ask

@mikehardy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have tagged @chrislongros - as commit messages are not normally a great venue for communication and you likely will never see this otherwise unlike, an actual issue report where github will give you an auto-subscription when you log it

@david-allison
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislongros That's a result of you using the Anki beta. Update to the RC and reoptimize and the issue will go away

Please sign in to comment.