Skip to content

Commit

Permalink
Revert "fix: preserve debuggability even in minimized release mode"
Browse files Browse the repository at this point in the history
This reverts commit aa271f9.

It appears to cause problems, and there were crashes in 2.19beta4-6
that appear to be related to it

It should work, and the failure has not been characterized yet

Fixes 17256
  • Loading branch information
mikehardy authored and david-allison committed Oct 15, 2024
1 parent 7f23bf2 commit 1969b28
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion AnkiDroid/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@
# debugging stack traces.
-keepattributes SourceFile,LineNumberTable

# #17256: `-dontobfuscate` caused crashes in SDK 26 (release mode):
# java.lang.NoSuchMethodError: No direct method <init>(II)V in class Lorg/apache/http/protocol/HttpRequestExecutor; or its super classes (declaration of 'org.apache.http.protocol.HttpRequestExecutor' appears in /system/framework/org.apache.http.legacy.boot.jar)
# The underlying cause has not been investigated, reinstate this line when fixed

# We do not have commercial interests to protect, so optimize for easier debugging
-dontobfuscate
# -dontobfuscate

# Used through Reflection
-keep class com.ichi2.anki.**.*Fragment { *; }
Expand Down

0 comments on commit 1969b28

Please sign in to comment.