-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user canceled #517
base: master
Are you sure you want to change the base?
Fix user canceled #517
Conversation
…rror) might come double now, but better double then not receiving the errors
|| responseCode == BillingClient.BillingResponseCode.ITEM_UNAVAILABLE | ||
|| responseCode == BillingClient.BillingResponseCode.DEVELOPER_ERROR | ||
|| responseCode == BillingClient.BillingResponseCode.ERROR | ||
|| responseCode == BillingClient.BillingResponseCode.ITEM_ALREADY_OWNED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BillingClient.BillingResponseCode.ITEM_ALREADY_OWNED
should be removed here as it is already handled in the else branch above
@max-critcrew can you please clean up all the extra changes in the PR? (anything except |
@serggl Without the extra changes, it wouldn't compile on https://jitpack.io/ - so these are necessary in order to make it work for testing. Do you know any other way how I can make it work? Absolutely agree about the About possible double issues: I am not entirely sure which of the errors that I am catching here and calling |
@max-critcrew this project is published via maven central, so these extra changes are not required. Also the licence key in the sample project does not really needs to be changed to compile, right? |
See: #516
fixed various issues that caused the payment flow not call the listeners (e.g. when the user canceled or item was unavailable, etc.)
Some of the additionally triggered listeners like developer error might trigger double now, but better double then not receiving the errors. If any library author could double check that'd be awesome.