Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add did resolver #123

Merged
merged 2 commits into from
Apr 24, 2023
Merged

feat: add did resolver #123

merged 2 commits into from
Apr 24, 2023

Conversation

TimoGlastra
Copy link
Member

@TimoGlastra TimoGlastra commented Apr 14, 2023

Adds support resolving did documents. Wasn't 100% about how to show the form + then the JSON of the did document. Any feedback on how to display it differently is welcome!

Trying to add some screenshots but internet is scarce...

Screen.Recording.2023-04-14.at.20.05.36.mov

@berendsliedrecht
Copy link
Member

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

@codecov-commenter
Copy link

Codecov Report

Merging #123 (e754cc6) into main (ea90fdb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          11       11           
  Lines          43       43           
  Branches        3        3           
=======================================
  Hits           33       33           
  Misses         10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TimoGlastra
Copy link
Member Author

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

Yeah that's a good idea. I tried to extract them based on the registered ones, but it's quite hard to do in 0.3.x. If we update to 0.4.x it would be simpler to extract the registered methods.

@berendsliedrecht
Copy link
Member

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

Yeah that's a good idea. I tried to extract them based on the registered ones, but it's quite hard to do in 0.3.x. If we update to 0.4.x it would be simpler to extract the registered methods.

Alrighty, can you create an issue and then we will pick it up later :).

@TimoGlastra
Copy link
Member Author

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

Yeah that's a good idea. I tried to extract them based on the registered ones, but it's quite hard to do in 0.3.x. If we update to 0.4.x it would be simpler to extract the registered methods.

Alrighty, can you create an issue and then we will pick it up later :).

#124

@TimoGlastra TimoGlastra merged commit 68fedd4 into main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants