feat: initial 0.5.0 support #87
Conversation
Signed-off-by: Timo Glastra <[email protected]>
apps/expo/index.js
Outdated
| // TODO: why is this needed since update to 0.5.0? | ||
| import 'fast-text-encoding' |
There was a problem hiding this comment.
Still need to figure out what library is using TextEncoder / TextDecoder.
Askar used it in 0.1.0 and that's why it was imported, but not sure why it's needed now
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
|
@janrxyz I've updated everything for Credo 0.5 and also updated Expo to 50. However there seems to be something wrong with the styling now in Tamagui. And TBH I understand very little of how it all works. Could you maybe take a look and see why it's behaving weirdly? Last thing to do before we can release a new version |
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
|
@TimoGlastra What seems to be the issue? It looks okay and the ci also succeeds |
|
Did you run it? The styling is definitely off if you compare it with the version from the app store |
Signed-off-by: Timo Glastra <[email protected]>
|
|
||
| // TODO: rotate the old wallet key to a new raw key |
There was a problem hiding this comment.
Have you checked the TODOs? Is this for now or later?
There was a problem hiding this comment.
This is a new todo for later. I discovered we are using uuids as the wallet key, while it's more secure and faster to generate a RAW wallet key if we're storing them in the secure enclave anyway.
However migrating old wallets to this new method is more work, so I stopped on it as I was getting distracted with the main purpose of this PR.
Should be a ticket though
| } | ||
| } | ||
|
|
||
| // NOTE: logo is used in issuer display (not sure if that's right though) |
There was a problem hiding this comment.
Why would that not be right? Should it be in the credential display?
There was a problem hiding this comment.
Both issuer and credential have a logo. We use the logo from the issuer, and the background_image from the credential.
But in that case we don't render the logo of the credential (then we could have two logos). So more a note that we don't render it at the moment
There was a problem hiding this comment.
Both issuer and credential have a logo. We use the logo from the issuer, and the background_image from the credential.
But in that case we don't render the logo of the credential (then we could have two logos). So more a note that we don't render it at the moment
There was a problem hiding this comment.
👍
Would have to think about where we place this. Is this credential logo new? Have you seen other implementations on how people render it? It's not on our original design or sphereons (maybe they updated it).
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const { _sd_alg, _sd_hash, iss, vct, cnf, ...visibleProperties } = decodedPayload | ||
|
|
||
| // TODO: display somehow which fields can be selective disclosed |
There was a problem hiding this comment.
Do we track this in code, or should we add it to a sprint board somewhere? I was testing with the wallet the other day and also saw that predicates for didcomm presentation requests are also not correct. Might be good to fix this sometime.
There was a problem hiding this comment.
Ah that predicates are not correct should not happen. Can you describe what the exact issue is?
I think we should start tracking these as tickets as well yes. I'll do a pass soon to get all these tickets in
There was a problem hiding this comment.
It's this FIXME:
Yeah fair. All of them are not for now, I'll add them to the board |
Signed-off-by: Timo Glastra <[email protected]>
Needs Sphereon-Opensource/OID4VC#87 to properly work
Also probably want to wait for stable 0.5.0 but everything is working (with a few minor hacks)