some fixes and updates #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
changed the title
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
fix/some-fixes
branch
from
0e7c8c4 to
c49a5f9
Compare
Signed-off-by: Timo Glastra <[email protected]>
janrtvld
approved these changes
Dec 3, 2024
| @@ -165,7 +165,7 @@ export const SlideWizard = forwardRef( | |||
| color={isError ? 'danger' : 'primary'} | |||
| /> | |||
| </Stack> | |||
| <AnimatedStack pos="relative" style={animatedStyles} jc="space-between" fg={1}> | |||
| <AnimatedStack style={animatedStyles} flex={1} jc="space-between"> | |||
There was a problem hiding this comment.
Is this intentional, and does this not break things on other screens?
There was a problem hiding this comment.
Ah good question. this is of course not only used in this page. But yes it's intentional. If the content was longer than the screen the screen would overflow for the length of the component above. But will check if this doesn't break anything on the other screens.
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three features / fixed in one PR 🙈