feat: federation in the wallet #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan <[email protected]>
TimoGlastra
reviewed
Nov 26, 2024
| import { useLocalSearchParams } from 'expo-router' | ||
|
|
||
| export default function Screen() { | ||
| const { entityId, trustedEntityIds, name, logo } = useLocalSearchParams() |
There was a problem hiding this comment.
We can provide the types here
Suggested change
| const { entityId, trustedEntityIds, name, logo } = useLocalSearchParams() | |
| const { entityId, trustedEntityIds, name, logo } = useLocalSearchParams<{ entityId: string, etc... }>() |
TimoGlastra
reviewed
Nov 26, 2024
| @@ -54,7 +58,9 @@ export const VerifyPartySlide = ({ | |||
| } | |||
|
|
|||
| const onPressVerifiedIssuer = withHaptics(() => { | |||
| router.push(`/issuer?entityId=${entityId}`) | |||
| router.push( | |||
| `/issuer?name=${name}&logo=${logo?.url}&entityId=${entityId}&trustedEntityIds=${trustedEntityIds?.join(',') ?? ''}` | |||
There was a problem hiding this comment.
The route changd right?
Suggested change
| `/issuer?name=${name}&logo=${logo?.url}&entityId=${entityId}&trustedEntityIds=${trustedEntityIds?.join(',') ?? ''}` | |
| `/federation?name=${name}&logo=${logo?.url}&entityId=${entityId}&trustedEntityIds=${trustedEntityIds?.join(',') ?? ''}` |
Comment on lines
33
to
37
| const entityPromises = TRUSTED_ENTITIES.map((entityId) => | ||
| openId4VcSiopHolderService.fetchOpenIdFederationEntityConfiguration(agent.context, { | ||
| entityId, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Why do'nt we just fetch an entity when we get a request? Why do we need to pre-fetch this?
| @@ -496,6 +498,22 @@ export const getCredentialsForProofRequest = async ({ | |||
| resolved.authorizationRequest.authorizationRequestPayload.client_metadata | |||
| } | |||
|
|
|||
| let verifiedEntityIds: Record<string, boolean> | undefined = undefined | |||
| if (entityId) { | |||
| const resolvedChains = await agent.modules.openId4VcHolder.resolveOpenIdFederationChains({ | |||
There was a problem hiding this comment.
Here we should return the metadata for the federation entity
apps/easypid/src/features/wallet/FunkeFederationDetailScreen.tsx
Outdated
Show resolved
Hide resolved
TimoGlastra
reviewed
Nov 26, 2024
| @@ -122,6 +122,7 @@ export function FunkeMdocOfflineSharingScreen({ | |||
| hostName: undefined, | |||
| logo: undefined, | |||
| name: 'Unknown party', | |||
| verifiedEntityIds: undefined, | |||
TimoGlastra
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.