feat: bPrime flow functionality #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
force-pushed
the
b-prime
branch
2 times, most recently
from
66da8ea to
12ad004
Compare
berendsliedrecht
force-pushed
the
b-prime
branch
6 times, most recently
from
df23bb4 to
fe3643b
Compare
TimoGlastra
reviewed
Aug 15, 2024
| <Button.Outline | ||
| p="$0" | ||
| width="$buttonHeight" | ||
| onPress={() => setSelectedFlow(selectedFlow === 'c' ? 'bprime' : 'c')} |
There was a problem hiding this comment.
should use callback where the current value is passed to prevent weird inconsistencies
Suggested change
| onPress={() => setSelectedFlow(selectedFlow === 'c' ? 'bprime' : 'c')} | |
| onPress={() => setSelectedFlow((selectedFlow) => selectedFlow === 'c' ? 'bprime' : 'c')} |
TimoGlastra
reviewed
Aug 15, 2024
|
|
||
| export type ReceivePidUseCaseState = 'id-card-auth' | 'acquire-access-token' | 'retrieve-credential' | 'error' | ||
|
|
||
| export class ReceivePidUseCaseBPrimeFlow { |
There was a problem hiding this comment.
I guess ok, but a lot of duplication between c and b' flow
TimoGlastra
reviewed
Aug 15, 2024
apps/funke/app/(app)/index.tsx
Outdated
| import { useSafeAreaInsets } from 'react-native-safe-area-context' | ||
| import { ReceivePidUseCaseCFlow, type ReceivePidUseCaseState } from '../../use-cases/ReceivePidUseCaseCFlow' | ||
|
|
||
| export default function Screen() { |
TimoGlastra
reviewed
Aug 15, 2024
| @@ -0,0 +1,111 @@ | |||
| import { type Key, KeyType, getJwkFromKey } from '@credo-ts/core' | |||
| import type { FullAppAgent } from '@package/agent' | |||
| import { createPinDerivedEphKeyPop, deriveKeypairFromPin } from '../crypto/bPrime' | |||
There was a problem hiding this comment.
we now have a src directory. Also how does this relate to receivePidBPrimeFlowUsecase ?
TimoGlastra
approved these changes
Aug 15, 2024
added 3 commits
August 19, 2024 12:22
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
b-prime
branch
from
fe3643b to
5b66276
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
b-prime
branch
from
5b66276 to
4004465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]