feat: authenticated screens and pid receiving #130
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
|
@berendsliedrecht still need to wait for the other PRs for it to work, but the code is complete. Please note that this is really an intermediate state as I will still be doing a lot of refactoring. So this is just to get the base working flow in. So feel free to comment on whatever, but I may push some things to upcoming PRs if that's easier |
Signed-off-by: Timo Glastra <[email protected]>
| @@ -6,23 +6,14 @@ const variants = { | |||
| development: { | |||
| bundle: '.dev', | |||
| name: ' (Dev)', | |||
| trustedCertificates: [ | |||
There was a problem hiding this comment.
Ill likely encounter it later, but why was this removed?
There was a problem hiding this comment.
I just couldn't get it to work. The value was not availalbe in the app. So after spending an hour on it, I just moved it to constants file
| const secureUnlock = useSecureUnlock() | ||
|
|
||
| // Wallet is not configured yet. Redirect to onboarding | ||
| if (secureUnlock.state === 'not-configured') { |
There was a problem hiding this comment.
enum would be nicer, can be done in the future as in improvement.
There was a problem hiding this comment.
same as with the href routing.
apps/funke/app/onboarding/index.tsx
Outdated
| void SplashScreen.hideAsync() | ||
|
|
||
| const onboarding = () => { | ||
| secureUnlock.setup('123456', { |
There was a problem hiding this comment.
Same here re change to user input pin
| export const FUNKE_WALLET_SEED_CREDENTIAL_RECORD_ID = 'FUNKE_WALLET_SEED_CREDENTIAL_RECORD_ID ' | ||
| export const FUNKE_WALLET_INSTANCE_LONG_TERM_AES_KEY_ID = 'FUNKE_WALLET_INSTANCE_LONG_TERM_AES_KEY_ID' | ||
|
|
||
| const TRUSTED_CERTIFICATES = ExpoConstants.expoConfig?.extra?.trustedCertificates as [string, ...string[]] | undefined | ||
| // https://demo.pid-issuer.bundesdruckerei.de | ||
| const bdrPidIssuerCertificate = `-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
My preference would be to get it from the app config, but not too opinionated about it.
| "compilerOptions": { | ||
| "rootDir": "./", | ||
| "paths": { | ||
| "@/*": ["./apps/funke/*"] |
There was a problem hiding this comment.
I am not really fan of the @/ style. Can we just do @app/*? Makes way more sense to me as @/ is quite vague.
| return this.currentState | ||
| } | ||
|
|
||
| private static SD_JWT_VC_OFFER = |
There was a problem hiding this comment.
Are these static values permament or just for testing?
| const { rawHash } = await argon2(pin, salt, { | ||
| hashLength: 32, | ||
| mode: 'argon2id', | ||
| parallelism: 4, | ||
| iterations: 1, | ||
| memory: 21, | ||
| iterations: 8, |
There was a problem hiding this comment.
Why did the values change? Did we not receive these form a spec?
There was a problem hiding this comment.
react-native-argon2 would crash. Did you test it with the previous values? This now takes around 1 sec on my phone. Wanted to do another check later to make it work also on android / older devices
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
This PR adds support for receiving an SD-JWT VC from the Funke PID issuer, as well as adds the authenticated screens structure (wallet, onboarding, authentication).
It won't work until the following PRs have been released and merged: