store seed credential #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
force-pushed
the
store-seed-credential
branch
2 times, most recently
from
6a74ae6 to
804d260
Compare
TimoGlastra
reviewed
Jul 30, 2024
Comment on lines
4
to
28
| const store = async (context: AgentContext, id: string, value: Record<string, unknown>) => { | ||
| const wallet = context.wallet | ||
| assertAskarWallet(wallet) | ||
|
|
||
| wallet.withSession(async (session) => { | ||
| session.insert({ | ||
| name: id, | ||
| value: JSON.stringify(value), | ||
| category: 'genericStorageRecord', | ||
| }) | ||
| }) | ||
| } | ||
|
|
||
| const replace = async (context: AgentContext, id: string, value: Record<string, unknown>) => { | ||
| const wallet = context.wallet | ||
| assertAskarWallet(wallet) | ||
|
|
||
| wallet.withSession(async (session) => { | ||
| session.replace({ | ||
| name: id, | ||
| value: JSON.stringify(value), | ||
| category: 'genericStorageRecord', | ||
| }) | ||
| }) | ||
| } | ||
|
|
||
| const getById = async <T extends Record<string, unknown>>(context: AgentContext, id: string): Promise<T> => { | ||
| const wallet = context.wallet | ||
| assertAskarWallet(wallet) | ||
|
|
||
| const item = await wallet.withSession(async (session) => | ||
| session.fetch({ | ||
| name: id, | ||
| category: 'genericStorageRecord', | ||
| }) | ||
| ) | ||
|
|
||
| if (!item) { | ||
| throw new Error(`No generic item with id: ${id} found`) | ||
| } | ||
|
|
||
| const transformedValue = item.value === 'string' ? JSON.parse(item.value) : item.value | ||
|
|
||
| return transformedValue as T | ||
| } | ||
|
|
||
| export const walletJsonStore = { | ||
| store, | ||
| getById, | ||
| replace, | ||
| } |
There was a problem hiding this comment.
We have agent.genericRecords for this. No need to use askar directory.
There was a problem hiding this comment.
Ah yeah makes sense, will swap.
berendsliedrecht
force-pushed
the
store-seed-credential
branch
from
804d260 to
703befe
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
store-seed-credential
branch
from
703befe to
bc98c1c
Compare
TimoGlastra
reviewed
Jul 30, 2024
| } else if (!offerUri) { | ||
| throw new Error('either data or uri must be provided') | ||
| throw new Error("either data or uri must be provided"); |
There was a problem hiding this comment.
I still have prettier setup, will run biome again...just a mistake.
berendsliedrecht
force-pushed
the
store-seed-credential
branch
from
bc98c1c to
223c9d0
Compare
TimoGlastra
reviewed
Aug 1, 2024
Comment on lines
125
to
151
| if (didMethod) { | ||
| const didResult = await agent.dids.create<JwkDidCreateOptions | KeyDidCreateOptions>({ | ||
| method: didMethod, | ||
| options: { | ||
| key, | ||
| }, | ||
| }) | ||
|
|
||
| if (didResult.didState.state !== 'finished') { | ||
| throw new Error('DID creation failed.') | ||
| } | ||
|
|
||
| let verificationMethodId: string | ||
| if (didMethod === 'jwk') { | ||
| const didJwk = DidJwk.fromDid(didResult.didState.did) | ||
| verificationMethodId = didJwk.verificationMethodId | ||
| } else { | ||
| const didKey = DidKey.fromDid(didResult.didState.did) | ||
| verificationMethodId = `${didKey.did}#${didKey.key.fingerprint}` | ||
| } | ||
|
|
||
| return { | ||
| didUrl: verificationMethodId, | ||
| method: 'did', | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
why did you remove this? This is needed for the Paradym WAllet?
There was a problem hiding this comment.
I don't think there was a reason, was just a bit too focussed on Funke wallet. Will revert.
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
store-seed-credential
branch
from
223c9d0 to
1158ded
Compare
TimoGlastra
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds ontop of #125