-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: push notifications #28
Conversation
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
… messaging Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
…ication service Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
feat: add fcm notification module
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
feat: upgrade credo to version 0.5.3
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
fix: imports for routing events
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
fix: add dotenv to dependencies
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
fix: docker file patches
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
chore: upgrade dependencies
Added a compass.yml file to manage this repository as a Compass component
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Ankita Patidar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good, just some small questions. Thanks!
} from './handlers' | ||
|
||
@injectable() | ||
export class PushNotificationsFcmApi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this compare to https://github.com/openwallet-foundation/credo-ts-ext/tree/main/packages/push-notifications/src/fcm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credo-ts-ext
doesn't have a Repository to store record so we added other files with https://github.com/credebl/mediator-agent/tree/refactor/mediator/src/push-notifications/fcm/repository. We will add this repository into credo-ext and later remove from mediator
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Summary
credo-ts
to latest versionsmessageType
. This helps us getting the message type and send notification to user based on message type (We can discuss this. further how we can achieve this without a patch)