Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature added: resume last playback #715

Closed
wants to merge 5 commits into from

Conversation

Yashraj254
Copy link
Contributor

Fix #687 added resume last playback button

sample11.mp4

@themd0
Copy link

themd0 commented Nov 13, 2023

what if the last played video, was streamed from a url ?

@Yashraj254
Copy link
Contributor Author

what if the last played video, was streamed from a url ?

it will be played from the beginning..

@themd0
Copy link

themd0 commented Jan 1, 2024

what if the last played video, was streamed from a url ?

it will be played from the beginning..

Couldn't find this feature in v0.10.2 but I'm sure you did a geat job

@Yashraj254
Copy link
Contributor Author

what if the last played video, was streamed from a url ?

it will be played from the beginning..

Couldn't find this feature in v0.10.2 but I'm sure you did a geat job

i have made the changes long ago it now works for url videos too, last playback video resume from where user left off, but the code is yet to get merged

# Conflicts:
#	feature/player/src/main/java/dev/anilbeesetti/nextplayer/feature/player/PlayerActivity.kt
@Yashraj254
Copy link
Contributor Author

Yashraj254 commented Jan 8, 2024

hey @anilbeesetti conflicts resolved, merge-ready. Appreciate any further feedback or changes.

# Conflicts:
#	core/model/src/main/java/dev/anilbeesetti/nextplayer/core/model/PlayerPreferences.kt
@anilbeesetti
Copy link
Owner

Thanks @Yashraj254 for your work. I appreciate you for your contributions to this project. I have implemented this in #884 in a different way that also make it possible to mark played and playing videos for each folder. That's why i'm closing this PR. Thanks once agian. And sorry for the late replies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Resume Last Playback Button
3 participants