Skip to content

Commit

Permalink
refactor(material/icon): provides context for undoing previous fix
Browse files Browse the repository at this point in the history
Updates notation to style change in icon.scss which undoes a previous
bug fix for GH issue #11826. As this change is now deemed as an
accessibility issue due to it being cut off/hidden.

Fixes b/250063405

BREAKING CHANGE: undoes hiding icon overflow

Reverts icon having its overflow visible to be more accessible.
  • Loading branch information
essjay05 committed Oct 23, 2024
1 parent 79c840b commit 7bf4cf7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/material/icon/icon.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ mat-icon {
}

// Makes button icon overflow visible to fix b/250063405
// Apply styles to avoid applying text-spacing to .mat-icon
// Undoes previous fix to Issue #11826 in preference of
// fixing to improve accessibility by not having the icon
// get cut off
overflow: visible;
}

Expand Down

0 comments on commit 7bf4cf7

Please sign in to comment.