This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix enum bug in module legacy namespace. #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually hold on. I think the bug is not fixed. Clutz produces different output depending on goog.module name I just got lucky in the test. |
nbeloglazov
force-pushed
the
b872
branch
2 times, most recently
from
dcf10b3
to
aea8d39
Compare
Related to angular#872. Tested: unit tests
|
Ready for review. |
nbeloglazov
changed the title
rkirov
reviewed
Oct 24, 2019
| @@ -1893,6 +1893,7 @@ private void visitEnumType(String symbolName, String qualifiedName, EnumType typ | |||
| emit(elementsTypeName); | |||
| emit(";"); | |||
| emitBreak(); | |||
| typesUsed.add(elementsTypeName); | |||
There was a problem hiding this comment.
does this fix the 'enu' or 'enum' test (or both)?
rkirov
approved these changes
Oct 24, 2019
|
Can you rebase, this looks good. |
|
This change doesn't work in one case like: goog.module('foo');
const bar = goog.require('bar');
/** @enum {number} */
const Color = bar.Color;
exports.Color = Color;where |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.