slider label #110
Merged
slider label #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slider label is set from two pathways with the first not correctly using the timezone. This has now been made consistent. The slider label wrapping wasn't disallowed but there isn't enough vertical space to support wrapping. In addition the animation control button wasn't fully allowed for and the optional 12 hour 'AM/PM' wasn't fully allowed for. I explored not passing in width and just going for 100%. Whilst it worked the font isn't constant width so it resulted in the time slider horizontally wobbling as it was dragged around. So I've kept the fixed width but left space for 'AM/PM'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slider label is set from two pathways with the first not correctly using the timezone. This has now been made consistent.
The slider label wrapping wasn't disallowed but there isn't enough vertical space to support wrapping. In addition the animation control button wasn't fully allowed for and the optional 12 hour 'AM/PM' wasn't fully allowed for. I explored not passing in width and just going for 100%. Whilst it worked the font isn't constant width so it resulted in the time slider horizontally wobbling as it was dragged around. So I've kept the fixed width but left space for 'AM/PM'.