Various fixes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grandthrax
commented
Dec 9, 2020
| SushiChef(chef).deposit(pid, _amount); | ||
|
|
||
| //i dont understand this part. You swap all reward into want in prepare return. Why would you have any to stake here? I can't see any situation where you'd be staking sushi |
There was a problem hiding this comment.
i understand now. ignore this comment
| @@ -185,7 +189,17 @@ contract StrategySushiswapPair is BaseStrategy { | |||
| function exitPosition(uint256 _debtOutstanding) internal override returns (uint256 _profit, uint256 _loss, uint256 _debtPayment) { | |||
| (uint256 _staked, ) = SushiChef(chef).userInfo(pid, address(this)); | |||
| SushiChef(chef).withdraw(pid, _staked); | |||
| //what about the money in xsushi? you just leave it there? | |||
There was a problem hiding this comment.
if you do transfer it remember to adjust 'staking'
andy8052
reviewed
Dec 9, 2020
| uint256 _xsushi = sushi_to_want(get_share_worth()); | ||
|
|
||
|
|
||
| uint256 _xsushi = sushi_to_want(get_share_worth()); //as you never realise this as profit you will need to change your harvest trigger method. Or else you could get in an endless true loop |
andy8052
reviewed
Dec 9, 2020
| @@ -134,6 +136,7 @@ contract StrategySushiswapPair is BaseStrategy { | |||
| */ | |||
| function prepareReturn(uint256 _debtOutstanding) internal override returns (uint256 _profit, uint256 _loss, uint256 _debtPayment) { | |||
| if (_debtOutstanding > 0) { | |||
| //this will crash is debtOutstaning is more than amount you have | |||
There was a problem hiding this comment.
I do not believe it is technically possible because it is a lossless strategy, but I will see if I can add a nice fix for it anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.