Update dependencies and remove automated plugins for other projects #217
Conversation
|
@yschimke if you're online it may be good to do an interim review before I'll update the other projects. |
| org-jetbrains-kotlinx = "1.6.0" | ||
|
|
||
| [libraries] | ||
| android-build-gradle = "com.android.tools.build:gradle:7.1.1" | ||
| android-lint-gradle = "com.android.tools.lint:lint-gradle:30.1.1" |
There was a problem hiding this comment.
This seems stricter, from CI failures.
> Task :views:lintDebug FAILED
/home/runner/work/wear-os-samples/wear-os-samples/AlwaysOnKotlin/views/src/main/AndroidManifest.xml:43: Error: Redundant label can be removed [RedundantLabel]
android:label="@string/app_name"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
Yeah, but it's even better. Should be fixed now
| @@ -3,73 +3,73 @@ org-jetbrains-kotlin = "1.6.0" | |||
| org-jetbrains-kotlinx = "1.6.0" | |||
|
|
|||
| [libraries] | |||
| android-build-gradle = "com.android.tools.build:gradle:7.1.1" | |||
| android-lint-gradle = "com.android.tools.lint:lint-gradle:30.1.1" | |||
There was a problem hiding this comment.
Same
/home/runner/work/wear-os-samples/wear-os-samples/RuntimePermissionsWear/Application/src/main/AndroidManifest.xml:38: Error: Redundant label can be removed [RedundantLabel]
android:label="@string/app_name"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| (it.candidate.version ==~ /.*-beta.*/ && !(it.currentVersion ==~ /.*-(beta|alpha).*/)) || | ||
| (it.candidate.version ==~ /.*1.6.20-M.*/) | ||
| ktlint("0.41.0") | ||
| licenseHeaderFile rootProject.file("spotless/copyright.kt") |
There was a problem hiding this comment.
Missing, but worth adding if it doesn't trigger a bunch of failures.
> java.nio.file.NoSuchFileException: /home/runner/work/wear-os-samples/wear-os-samples/WatchFaceKotlin/spotless/copyright.kt
There was a problem hiding this comment.
Copyright was missing (fixed now), but ktlint check fails as well, commented out it temporarily, but plan to take a look a bit later.
Activity label is not needed and can’t be removed since it’s the same as app label.
Fix build errors: - RuntimePermissionsWear - WatchFaceKotlin WatchFaceKotlin is failing due to ktlint error, need to investigate.
|
LGTM |
Update dependencies for WearSpeakerSample and fixed API compatibility changes for dialogs (see https://developer.android.com/jetpack/androidx/releases/wear-compose#1.0.0-alpha15) Check is failing due to ktlint error, need to investigate.
|
At least some of the android test failures seem unrelated, just timeouts. |
|
@yschimke yeah seem so, I checked all of them locally before pushing and they run successfully. |
|
I know it was a bit special this time. But hopefully we can make it simpler/automated and routine in future. |
|
Failures seem unrelated and |
|
Merging this PR with a note to investigate a possible workaround for flaky tests that seems to be a root cause for check failures in |
|
Raised #219 |
See #213 for context.