Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AGP and Compose versions #212

Closed
wants to merge 1 commit into from
Closed

Conversation

shumelchyk
Copy link
Collaborator

No description provided.

@alexvanyo
Copy link
Contributor

Just a note, it would probably make sense to update AGP and the Compose version across all samples and not just ComposeAdvanced (there isn't a central place to do that, just in each project individually)

@shumelchyk
Copy link
Collaborator Author

Good point, I can add dependencies updates for other samples within current PR. Moving forward - do we have any suggested best practices how to bump dependencies nicely across all repos (otherwise I'll investigate)?

@yschimke
Copy link
Contributor

@shumelchyk this is the way #213

@shumelchyk shumelchyk requested review from yschimke and removed request for slothwriter February 17, 2022 18:37
@shumelchyk
Copy link
Collaborator Author

shumelchyk commented Feb 17, 2022

#213 looks promising, let's try to integrate it, thanks @yschimke !

@shumelchyk shumelchyk closed this Feb 18, 2022
@shumelchyk
Copy link
Collaborator Author

Closing in favor of #215 and other changes landing within #213

@shumelchyk shumelchyk deleted the kshum-compose-updates branch February 18, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants