Skip to content

Commit

Permalink
[BE] Add regression test for aten shared build (pytorch#96697)
Browse files Browse the repository at this point in the history
To expose errors similar to pytorch#94401 (comment) in OSS CI

Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain.

Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386

Pull Request resolved: pytorch#96697
Approved by: https://github.com/kit1980
  • Loading branch information
malfet authored and pytorchmergebot committed Mar 14, 2023
1 parent a22b92d commit 5a8a403
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions .buckconfig.oss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

[cxx]
cxxflags = -std=c++17
ldflags = -Wl,--no-undefined
should_remap_host_platform = true
cpp = /usr/bin/clang
cc = /usr/bin/clang
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/_buck-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
timeout_minutes: 10
max_attempts: 5
command: |
sh scripts/buck_setup.sh
bash scripts/buck_setup.sh
- name: Build tools
run: |
Expand Down Expand Up @@ -122,3 +122,7 @@ jobs:
- name: Build everything
run: |
buck build //... --keep-going
- name: Build aten_cpu@shared
run: |
buck build :aten_cpu#linux-x86_64,shared

0 comments on commit 5a8a403

Please sign in to comment.