Refactoring #127
Merged
Refactoring #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #127 +/- ##
==========================================
+ Coverage 97.76% 97.81% +0.04%
==========================================
Files 25 25
Lines 1479 1467 -12
==========================================
- Hits 1446 1435 -11
+ Misses 33 32 -1 ☔ View full report in Codecov by Sentry. |
andrey-zherikov
added a commit
that referenced
this pull request
Dec 11, 2023
* Refactor (#96) * Move onError tp api/cli.d * Improve ANSI styling handling and making AnsiStylingArgument boolean-like * Make Parser private * Remove hooks * Remove subcommands * Remove argumentparser * Update readme * Add unit tests * Rename Config.helpStyle to Config.styling (#97) * Add unit test (#98) * Refactor (#99) * Small cleanup * Make Config a template parameter * Add unit test * Styling in error messages (#100) * Add errorMessagePrefix to Style * Rename Style.namedArgumentName => Style.argumentName * Styling in error messages * Add check for argument name (#101) * Rename Config.namedArgChar to namedArgPrefix (#102) * Add checks for positional arguments (#103) * Refactor (#105) * Add ArgumentInfo.memberSymbol * Small refactoring * Move Restriction and RestrictionGroup to internal.restriction * Remove symbol parameter * remove partial apply * Small refactoring * Small refactoring * Add unit test * Pin LDC to 1.34.0 (#108) * Add '--verbose' to builds * Refactoring (#127) * Required positional arguments must come before optional ones * Optional positional arguments are not allowed with default subcommand * Rewrite parser (#128) * Refactor * Split ArgumentInfo.names to shortNames and longNames * Add namedArguments and positionalArguments to Arguments * Rename Arguments.arguments to info * Refactor Arguments API * Remove ArgumentInfo.ignoreInDefaultCommand * Rewrite parser * unit tests * Update readme (#121) * Update readme * Update the examples as well * Apply suggested changes to readme * Declare `Style.Default` with an alternative syntax (#130) * Turn `main` and `mainComplete` into regular templates (#132) They don't need advanced features that template mixins provide. (Regular templates are mixable, too.) https://dlang.org/spec/template-mixin.html * Make Styling API `nothrow pure @safe` (#133) * Reduce allocations in Styling API (#134) * Reduce allocations in Styling API * Remove the overload of `TextStyle.opCall` that takes a sink We should make `StyledText` a range instead. * Do not depend on `std.regex` (#131) * Do not depend on `std.regex` This saves 1.5 MB in the binary, which is desirable since not every program that uses `argparse` may want to use regexes - or that particular implementation of regexes. `argparse.ansi.getUnstyledText` became eager, but the library wasn't exploiting its laziness anyway. * Make `getUnstyledText` lazy and `@nogc` * Use constants instead of hardcoded characters * Rework the auxiliary function Co-Authored-By: Andrey Zherikov <[email protected]> * Remove one mutable variable * Add a small comment --------- Co-authored-by: Andrey Zherikov <[email protected]> Co-authored-by: Andrey Zherikov <[email protected]> * Improve compilation time and memory (#124) * Use regular parameters instead of template parameters where possible This helps in reducing both compilation time and (build-time) memory requirement. * Deduplicate `HelpArgumentUDA.parse` 2.3 GB -> 1.7 GB. * Deduplicate `Complete.CompleteCmd` 1.7 GB -> 1.6 GB. * Compile the completer on demand 1.6 GB -> 0.8 GB. * Simplify `CLI!(...).complete` * Deduplicate `CounterParsingFunction` * Make some of the config's fields statically known by the parser So that the compiler can prune dead branches of code. * Remove `assignChar` from parser's template parameters * Try to simplify min-max-handling logic in `getMemberArgumentUDA` * Add a unit test for `getMemberArgumentUDA` * Move `getArgumentUDA` to `argparse.internal.arguments` Renamed into `finalize` in the process. It only fills `ArgumentInfo` so it doesn't have to know about UDAs at all. * Import non-std modules once per file --------- Co-authored-by: Nickolay Bukreyev <[email protected]> Co-authored-by: Andrey Zherikov <[email protected]>
andrey-zherikov
added a commit
that referenced
this pull request
Dec 12, 2023
andrey-zherikov
added a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 1990597)
andrey-zherikov
added a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 1990597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.