Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Filter options (sndspeed but more UX friendly) #343

Closed
wants to merge 2 commits into from

Conversation

drHyperion451
Copy link

Adds a "Sound filter" option under "game" section in options. It switches on-off the low-pass filter which is applied when the game is resampling a 11.125 kHz audio to 44.1 kHz (so it rids off the "crunch-ness" effect that creates the resampling.

imagen

This is a continuation of #314 which was mistakenly closed because I made a force pull request. In that thread we discuss how to solve this problem.

Also this changes the sndspeed option to be snd_filter for some reasons:

  1. There's already a snd_filterquality variable, that does exactly what it says, so it fits well with snd_filter
  2. sndspeed was either way a switch between 11125 and other values. It's pointless to have an exact numerical value and leaves confussion. A boolean option should be more intuitive.
  3. Bad naming in my viewpoint. What is sound "speed"?
  4. Theres already snd_mixspeed that actually does change the sample rate in more intervals.

snd_filter is now a boolean value instead of a boolean value hidden under an int value. Also this cvar is persistent in the user options (unlike sndspeed)

Still I should change the on/off switch to a more suitable "classic vs remastered" or "retro vs off" to give more hints to the user (like how it's done in the models option under the graphics section). When I do change it I will mark this PR as ready.

I'm not an expert or a professional, any feedback will be appreciated. It's a small change but pretty necesary (#169)

- sndspeed is now changed with snd_filter
- The option is inside "game"

To be done: Make it swich between "off" and "retro" or "remaster" and "classic"
@drHyperion451
Copy link
Author

Read @L-P comment too late. Closing this PR because it's unnecesary now. (#314 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant