Sound Filter options (sndspeed but more UX friendly) #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Sound filter" option under "game" section in options. It switches on-off the low-pass filter which is applied when the game is resampling a 11.125 kHz audio to 44.1 kHz (so it rids off the "crunch-ness" effect that creates the resampling.
This is a continuation of #314 which was mistakenly closed because I made a force pull request. In that thread we discuss how to solve this problem.
Also this changes the
sndspeed
option to besnd_filter
for some reasons:snd_filterquality
variable, that does exactly what it says, so it fits well withsnd_filter
snd_mixspeed
that actually does change the sample rate in more intervals.snd_filter
is now a boolean value instead of a boolean value hidden under an int value. Also this cvar is persistent in the user options (unlikesndspeed
)Still I should change the on/off switch to a more suitable "classic vs remastered" or "retro vs off" to give more hints to the user (like how it's done in the models option under the graphics section). When I do change it I will mark this PR as ready.
I'm not an expert or a professional, any feedback will be appreciated. It's a small change but pretty necesary (#169)