Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare suitability for v11 of TYPO3 #7

Closed
wants to merge 2 commits into from

Conversation

ChrisB9
Copy link
Collaborator

@ChrisB9 ChrisB9 commented Jan 6, 2022

This already enables the v11 support.
We should consider:

  • add a new version branch that only supports v10 and v11
  • make it php 7.4, php 8.0 and php 8.1 only
  • refactor and remove legacy code
  • add github workflow for phpstan & phpcs

Note: I think we should furthermore consider during all that refactoring #6

@NarkNiro
Copy link
Collaborator

NarkNiro commented Jan 7, 2022

According to Composer we still support TYPO3 v8 and v9 in these there is no dependency injection yet =/

@ChrisB9
Copy link
Collaborator Author

ChrisB9 commented Jan 7, 2022

which is why I would like to drop support for it

@andreaswolf
Copy link
Owner

I merged #8 now, but I think we should add some parts of this as well – at least the CI parts, the class finalization and the restriction to PHP 7.4+ would be beneficial IMO.

@ChrisB9
Copy link
Collaborator Author

ChrisB9 commented Sep 8, 2022

Should we then continue with this MR or break those ideas into multiple requests and drop the namespace change?

@ChrisB9
Copy link
Collaborator Author

ChrisB9 commented Sep 12, 2022

I am going to close this as we added github actions through #14 and #15
I'll add an issue for the namespace topic

@ChrisB9 ChrisB9 closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants