Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper uiTableModel stamps for unix. #505

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szanni
Copy link

@szanni szanni commented Aug 20, 2020

Unix:

  • Add dynamic iter stamps to uiTableModel - similar to GtkListStore.
  • Add proper logging for invalid iter use instead of silently aborting.

The logging actually brought up issue #504. The second commit in this pr fixes that issue.

The dynamic iter stamps are additionally a stepping stone for a sort model - hopefully soon to come.

szanni added 2 commits August 19, 2020 13:22
- Make model stamps random on init.
- Use g_return_*_if_fail functions to log errors of invalid stamp use.
Remove the iter stamp check from uiTableModel_iter_nth_child:
This is a setter for iter, so no checks should be performed.

As reference: both GtkListStore and GtkTreeStore do not perform
any checks on iter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant