Add uiSliderSetRange function to API #381
Conversation
|
Works on Windows 10.
|
|
Check the appveyor CI, there is a build error on Visual Studio 2013: (https://ci.appveyor.com/project/andlabs/libui/build/build%20%2372/job/t3rx2mtgcf7sap7v) |
|
Classic Windows not supporting the C standard. Apparently VS only started supporting the snprintf function as of 2015: https://social.msdn.microsoft.com/forums/vstudio/en-US/2b339bdf-7ab1-4a08-bf7e-e9293801455b/c99-standard-snprintf-function- What is the best course of action here? The CONTRIBUTING.md states C++11 compatibility, snprintf is C99 so should be included. I know Microsoft thinks otherwise. Should I change it to sprintf, make the buffer 12 char and assert() an Int has a max of 32 bits? Or forget about the testcases compiling prior to VS 2015? Not sure if that would be the right approach. |
|
Yeah, I ran into this omission once before in the tester. And yeah, the final version of C++11 does state |
|
VS2013 has _snprintf |
|
Updated the branches. Should compile on VS2013 now too. |
|
Any chance of getting this merged? Anything blocking this pr? |
|
👍 from a bindings perspective. Currently in proton-native, updating a slider's range means removing all children (because there is no |
…tion. Some applications need to modify the slider range at runtime. Instead of re-creating a slider with a new range, provide a function to modify the range of an existing uiSlider.
Add a function to the slider API to modify the slider range after slider creation.
This is useful for e.g. media players that reset the range with every track -> without having to resort to deleting the existing slider and creating a new one with all signals etc.
THE WINDOWS CODE HAS NOT BEEN TESTED
I sadly don’t have a windows machine at hand right now, but looking at the MSDN docs this should work.
I did not adhere completely to the style doc either - with regards to the temp variable, which is declared within the scope of the if block. Less lines, more screen estate. If this is ok I’d be willing to adjust the style guide to add this exception. If not here is the same content adhering strictly to the style guide:
https://github.com/szanni/libui/tree/uiSliderSetRange-formatting